-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt ChargedHadronPFTrackIsolationProducer for PFTICL candidates (backport) #32316
Adopt ChargedHadronPFTrackIsolationProducer for PFTICL candidates (backport) #32316
Conversation
A new Pull Request was created by @hatakeyamak (Kenichi Hatakeyama) for CMSSW_11_1_X. It involves the following packages: RecoParticleFlow/PFProducer @perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
backport of #32202 |
@cmsbuild please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
assign upgrade |
New categories assigned: upgrade @kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks |
@hatakeyamak yes - my policy is not to sign backports until the master PR is integrated and has been demonstrated not to cause any problems in IBs |
Sounds reasonable. Thx for clarification. |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This backport addresses PF to run with recent HGCAL update #31907. More in detail this will allow ChargedHadronPFTrackIsolationProducer to accommodate PF candidates which don't go through the PFBlock mechanism.
PR validation:
Tested with matrix test 23234.0 (ttbar 2026 D49) under CMSSW_11_1_5 with #31907 and --customise RecoHGCal/TICL/iterativeTICL_cff.injectTICLintoPF. With this PR, matrix test runs without a crash.
For more validation, see the original PR #32202.
if this PR is a backport please specify the original PR and why you need to backport that PR:
This is a backport of #32202.
@bendavid @rovere @felicepantaleo @hqucms